I signed the CLA yesterday. Not sure why that check is failing.

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@dansajner did you sign it with a mail address that isn't the one in your github profile or the one you used in the commit?

Looks like my my global git config has a different email address than the one I signed with, but what I signed with matches my github profile.

@bastelfreak do I need to push an update with a different email address? I pushed a fix to the tests so those should pass if run again.

Hey @dansajner, sorry for the delayed response here - this looks great, thanks for the PR. The CLA check looks good. 👍

Sorry for the inconvenience, but I've been updating some of the CI scripts for the repository and it's created a minor conflict so Travis can't test the PR. Could you update your branch with the latest from master and push again so it'll get picked up and tested?

From my perspective your changes look good, barring any flags from the test suite.

The intake tests are showing a failure when setting a variable to the empty string. I actually wasn't familiar with that check (results of inheriting the project), but after looking at the check's documentation I'm pretty sure this is a valid case for the empty string. According to the puppet lint docs we should be able to include something like the following surrounding the assignment to make the linter happy.

# lint:ignore:empty_string_assignment
$ssl_args = ''
# lint:endignore

@tylerjl all tests are passing.